Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet Server docs #585

Merged
merged 9 commits into from
Apr 30, 2021
Merged

Add Fleet Server docs #585

merged 9 commits into from
Apr 30, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Apr 23, 2021 •
edited
Loading

Closes #449

@dedemorton dedemorton self-assigned this Apr 23, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Apr 23, 2021 •
edited
Loading

A documentation preview will be available soon:

EricDavisX
EricDavisX suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@EricDavisX EricDavisX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great work! hope the suggestions / notes are further helpful - happy to re-review. hopefully the product UI and specs are settling and will be available to help drive our confidence in what we're trying to document!

ruflin
ruflin approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Would be nice to get the basic structure in quickly so we can all start to collaborate on it.

docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Show resolved Hide resolved
docs/en/ingest-management/fleet/fleet-server.asciidoc Outdated Show resolved Hide resolved
docs/en/ingest-management/tab-widgets/add-fleet-server/content.asciidoc Outdated

To add {fleet-server}:

//QUESTION: Do we want to show how to call the API to generate the token, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus on easy setup. Ideally the setup would have enough docs directly in the UI.

@dedemorton dedemorton mentioned this pull request Apr 29, 2021
Merged
@dedemorton dedemorton marked this pull request as ready for review April 30, 2021 00:16
@dedemorton dedemorton requested a review from a team as a code owner April 30, 2021 00:16
@dedemorton
Copy link
Contributor Author

@ruflin Can you review again? I think there might still be some fiction, but there's more detail now.

@dedemorton dedemorton requested review from ruflin and EricDavisX April 30, 2021 00:18
ruflin
ruflin approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As mentioned before, I don't think this needs to be perfect in the first iteration and I rather go through it again in detail after it is merged and make some adjustments directly and open a new PR. I think this will be more efficient.

@dedemorton dedemorton merged commit e43f37b into elastic:master Apr 30, 2021
@dedemorton dedemorton deleted the issue#449 branch April 30, 2021 20:33
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Apr 30, 2021
@dedemorton
Add Fleet Server docs (elastic#585)
024e447
@dedemorton dedemorton mentioned this pull request Apr 30, 2021
Merged
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Apr 30, 2021
@dedemorton
Add Fleet Server docs (elastic#585)
14b69bc
This was referenced Apr 30, 2021
Merged
Closed
dedemorton added a commit that referenced this pull request Apr 30, 2021
@dedemorton
Add Fleet Server docs (#585) (#607)
85e3441
dedemorton added a commit that referenced this pull request Apr 30, 2021
@dedemorton
Add Fleet Server docs (#585) (#606)
77433dc
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@dedemorton
Add Fleet Server docs (elastic#585)
06bf4a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@ruflin ruflin ruflin approved these changes

@EricDavisX EricDavisX Awaiting requested review from EricDavisX

Assignees

@dedemorton dedemorton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new topic about Fleet server
5 participants
@dedemorton @apmmachine @ruflin @bmorelli25 @EricDavisX